Remove the unused implicit attribute _cc_toolchains.#372
Closed
mikesinouye wants to merge 3 commits intomainfrom
Closed
Remove the unused implicit attribute _cc_toolchains.#372mikesinouye wants to merge 3 commits intomainfrom
_cc_toolchains.#372mikesinouye wants to merge 3 commits intomainfrom
Conversation
Signed-off-by: Mike Inouye <mikeinouye@google.com>
Signed-off-by: Mike Inouye <mikeinouye@google.com>
Signed-off-by: Mike Inouye <mikeinouye@google.com>
|
Can your project upgrade to Bazel 7.4.1? That should resolve the failure, and is much more up-to-date than the current version of 6.x. |
Collaborator
Author
|
While that is the best fix, briefly experimenting with bazel 7 seems like it requires a cascade of dependency upgrades/fixes. At this point, the time is likely better spent upgrading to bzlmod instead. @QuantamHD should we stick with bazel6 for now, resolve our internal issue with a patch, and plan to spend time for a proper bazel 8 + bzlmod migration sometime next year? |
Collaborator
|
Might want to just go with a patch internally, and move to bzlmod |
Collaborator
Author
|
Sounds good, let's go with that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC toolchains are gathered from the line: